git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] rev-list: skip bitmap traversal for --left-right

From
Taylor Blau <me@ttaylorr.com>
Date
Nov 1, 2024, 14:40 UTC
Message-ID
<ZyToaRxR7upLg0IE@nand.local>
In-Reply-To
<20241101121606.GA2327410@coredump.intra.peff.net>
On Fri, Nov 01, 2024 at 08:16:06AM -0400, Jeff King wrote:
>  builtin/rev-list.c      |  7 +++++++
>  t/t5310-pack-bitmaps.sh | 12 ++++++++++++
>  2 files changed, 19 insertions(+)

Nice find, and well explained (not just why it doesn't work today but could in the future, but why making it work in the future with bitmaps does not necessarily a clear performance improvement).

Probably you and I should think more about other rev-list options that *don't* work with --use-bitmap-index. I share your feeling there that there probably exist such options which silently do nothing (or the wrong thing) in the presence of '--use-bitmap-index'.

Let's merge this one down.

Thanks, Taylor

Previous: Jeff KingNext: Jeff King
Message 2 of 6 in “rev-list: skip bitmap traversal for --left-right”
  1. rev-list: skip bitmap traversal for --left-rightJeff King, Nov 1, 2024
  2. Taylor BlauNov 1, 2024
  3. Jeff KingNov 4, 2024
  4. Jeff KingNov 4, 2024
  5. Taylor BlauNov 4, 2024
  6. Ayush ChandekarFeb 2, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.