Re: [PATCH v3 0/8] Allow relative worktree linking to be configured by the user

From: Taylor Blau <me@ttaylorr.com>
Date: Oct 31, 2024, 19:20 UTC
Message-ID: <ZyPYiffYRDK/4LdG@nand.local>
In-Reply-To: <20241031-wt_relative_options-v3-0-3e44ccdf64e6@pm.me>

On Thu, Oct 31, 2024 at 05:05:23AM +0000, Caleb White wrote:

Show 9 quoted lines

> Caleb White (8):
>       setup: correctly reinitialize repository version
>       worktree: add `relativeWorktrees` extension
>       worktree: refactor infer_backlink return
>       worktree: add `write_worktree_linking_files()` function
>       worktree: add relative cli/config options to `add` command
>       worktree: add relative cli/config options to `move` command
>       worktree: add relative cli/config options to `repair` command
>       worktree: refactor `repair_worktree_after_gitdir_move()`

This version of the topic, as well as the previous round, appear to break CI:

    https://github.com/ttaylorr/git/actions/runs/11602969587

An easy reproduction locally is to run t/t5504-fetch-receive-strict.sh when built with 'make SANITIZE=leak' and run with 'GIT_TEST_DEFAULT_REF_FORMAT=reftable'.

I'm going to kick this topic out of jch for the time being as it breaks CI, but please do send another round once you have fixed the issue. In the future, please verify that your series does not break CI before sending it to the list. Thanks.

Thanks, Taylor