Re: [PATCH 01/11] midx: avoid duplicate packed_git entries

From: Taylor Blau <me@ttaylorr.com>
Date: Oct 25, 2024, 21:09 UTC
Message-ID: <ZxwJHY/BQJvpGT1s@nand.local>
In-Reply-To: <20241025064340.GA2110355@coredump.intra.peff.net>

On Fri, Oct 25, 2024 at 02:43:40AM -0400, Jeff King wrote:

Show 6 quoted lines

> +cc Stolee here as the original midx author. I can't think of a good
> reason we'd want to avoid this dup-detection here.
>
>  midx.c                        | 20 +++++++++++++++++---
>  t/t5200-update-server-info.sh |  8 ++++++++
>  2 files changed, 25 insertions(+), 3 deletions(-)

:-). I swear I have written this exact patch before. I think this was way back in the early days of MIDX bitmaps, and working around this bug was the reason that we don't generate the MIDX/bitmap at the end of a repack in the same process.

I don't recall all of the details at the time (or even if the above rationale was what I was thinking back then or not), but I think the change below here is obviously correct.

Thanks, Taylor