Re: [PATCH v2] t1016: clean up style

From: Taylor Blau <me@ttaylorr.com>
Date: Oct 22, 2024, 16:36 UTC
Message-ID: <ZxfUngQKdGZq2dWf@nand.local>
In-Reply-To: <20241022110730.7655-1-algonell@gmail.com>

On Tue, Oct 22, 2024 at 02:07:30PM +0300, Andrew Kreimer wrote:

Show 15 quoted lines

> Use `test_config`.
>
> Remove whitespace after redirect operator.
>
> Reported-by: Taylor Blau <me@ttaylorr.com>
> Signed-off-by: Andrew Kreimer <algonell@gmail.com>
> ---
> v1:
>   - https://lore.kernel.org/all/20241020121729.27032-1-algonell@gmail.com/
>
> v2:
>   - Base on "ak/typofix":
>     - https://lore.kernel.org/all/20241017112835.10100-1-algonell@gmail.com/
>   - Tested:
>     - ubuntu-latest, GitHub Actions.

Thanks. In the future, it's preferred to send subsequent rounds in a reply to the initial round so that the discussion all happens in the same thread.

Regardless, thank you for this patch, I've queued it. It looks good to me, but perhaps others could chime in before we start merging this one down.

Show 21 quoted lines

>  t/t1016-compatObjectFormat.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/t/t1016-compatObjectFormat.sh b/t/t1016-compatObjectFormat.sh
> index 92024fe51d..8341a2fe83 100755
> --- a/t/t1016-compatObjectFormat.sh
> +++ b/t/t1016-compatObjectFormat.sh
> @@ -116,8 +116,8 @@ do
>  		git config core.repositoryformatversion 1 &&
>  		git config extensions.objectformat $hash &&
>  		git config extensions.compatobjectformat $(compat_hash $hash) &&
> -		git config gpg.program $TEST_DIRECTORY/t1016/gpg &&
> -		echo "Hello World!" > hello &&
> +		test_config gpg.program $TEST_DIRECTORY/t1016/gpg &&
> +		echo "Hello World!" >hello &&
>  		eval hello_${hash}_oid=$(git hash-object hello) &&
>  		git update-index --add hello &&
>  		git commit -m "Initial commit" &&
> --
> 2.39.5
>

Thanks, Taylor