Re: [PATCH] t1016: clean up style

From: Taylor Blau <me@ttaylorr.com>
Date: Oct 21, 2024, 21:45 UTC
Message-ID: <ZxbLlA0xbuhP7DJK@nand.local>
In-Reply-To: <98c5e44f-42c9-47c7-9fa1-e6cc3b35cdb4@app.fastmail.com>

On Sun, Oct 20, 2024 at 02:46:18PM +0200, Kristoffer Haugsbakk wrote:

Show 28 quoted lines

> Hi
>
> On Sun, Oct 20, 2024, at 14:17, Andrew Kreimer wrote:
> > Use `test_config`.
> >
> > Remove whitespace after redirect operator.
> >
> > Reported-by: Taylor Blau <me@ttaylorr.com>
> > Signed-off-by: Andrew Kreimer <algonell@gmail.com>
> > ---
> > As discussed in:
> >   - https://lore.kernel.org/git/ZxFyKXDCJkRZYYQY@nand.local/
> > […]
> > -		git config gpg.program $TEST_DIRECTORY/t1016/gpg &&
> > -		echo "Hellow World!" > hello &&
> > +		test_config gpg.program $TEST_DIRECTORY/t1016/gpg &&
> > +		echo "Hellow World!" >hello &&
>
> What Taylor wrote:
>
> > Thanks, both. [Andrew] -- it's fine to do this in the same, or a
> > separate patch in the new round. Thanks.
>
> You’ve posted a new, standalone patch.  But what Taylor asked for was a
> new round on that typo patch where you either squash these changes into
> the original patch or have the typo patch plus this one.
>
> At least that’s how I understand it.

I said originally that either was fine, but then revised my statement after remembering that the original topic was already in 'next', so any further changes would have to be done on top.

Thanks, Taylor