Re: [PATCH v2 2/5] Makefile: adjust sed command for generating "clar-decls.h"
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Oct 21, 2024, 11:35 UTC
- Message-ID
- <ZxY8YL-dSlVVBT0K@pks.im>
- In-Reply-To
- <e3bf73c3-2f4a-4b49-9016-a455163616ca@app.fastmail.com>
On Mon, Oct 21, 2024 at 01:07:17PM +0200, Kristoffer Haugsbakk wrote:
Show 20 quoted lines
> On Mon, Oct 21, 2024, at 12:56, Patrick Steinhardt wrote: > > From: Alejandro R. Sedeño <asedeno@mit.edu> > > > > This moves the end-of-line marker out of the captured group, matching > > the start-of-line marker and for some reason fixing generation of > > "clar-decls.h" on some older, more esoteric platforms. > > > > Signed-off-by: Alejandro R. Sedeño <asedeno@mit.edu> > > Signed-off-by: Patrick Steinhardt <ps@pks.im> > > Alejandro used two signoffs in his original:[1] > > Signed-off-by: Alejandro R. Sedeño <asedeno@mit.edu> > Signed-off-by: Alejandro R. Sedeño <asedeno@google.com> > > I don’t know if this matters? > > See also https://lore.kernel.org/git/xmqqilc571hf.fsf@gitster.g/ > > 🔗 1: https://lore.kernel.org/git/20241012144027.2573690-1-asedeno@mit.edu/
It felt more like an accident than intent, but true, I should've asked. Alejandro, please let me know whether I should restore the second SOB.
Thanks for reading this carefully!
Patrick