git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [Outreachy][proposal]: Finish adding a 'os-version' capability to Git protocol v2

From
Patrick Steinhardt <ps@pks.im>
Date
Oct 28, 2024, 07:30 UTC
Message-ID
<Zx89jzejV3lMxWr8@pks.im>
In-Reply-To
<CAPSxiM92YO8askO7h=1jOy5PfOdrAfaKiSFv7aRL0iCT4BcTzg@mail.gmail.com>
On Mon, Oct 28, 2024 at 06:20:21AM +0000, Usman Akinyemi wrote:
Show 27 quoted lines
> On Mon, Oct 28, 2024 at 6:11 AM Patrick Steinhardt <ps@pks.im> wrote:
> > > ---- December 23 - February 10: Incremental Conversions & Feedback
> > > Integration -----
> > >
> > > - File Renaming: Rename test files from t-<name>.c to <name>.c
> > > following the structure outlined by prior contributions.
> > > - Clar Suite Integration: Add the module name to CLAR_TEST_SUITE in
> > > the Makefile to include the file in the Clar testing suite.
> > > - Conversion of Test Assertions: Replace the test assertions with
> > > Clar’s built-in functions (cl_assert, cl_assert_equal_s,
> > > cl_assert_equal_i, etc.), enhancing readability and functionality.
> > > -  Patch Submission: Submit each converted test as an incremental
> > > patch to Git's mailing list following the Git contribution guidelines.
> > > This phased approach enables targeted feedback from the community.
> >
> > One thing missing here is the work with upstream in case we want to
> > implement any functionality that doesn't yet exist in clar. You mention
> > it in "Additional Goals and Extensions" though, so that might be good
> > enough.
> >
> > Other than that this looks good to me, thanks! Please don't forget to
> > upload your applications to Outreachy if you haven't done so already.
> >
> Hi, Patrick
> Thanks for your review.
> Will it be better to include *work with upstream* as part of the whole
> timeline instead of adding it as an Additional Goals and Extensions?

I don't mind it too much, and as mentioned elsewhere I think that it's perfectly fine if the timeline is rough. It's more about demonstrating that you're aware of the steps, which you seem to be.

Patrick
Previous: Usman AkinyemiNext: Christian Couder
Message 5 of 11 in “[Outreachy][proposal]: Finish adding a 'os-version' capability to Git protocol v2”
  1. Usman AkinyemiOct 27, 2024
  2. Usman AkinyemiOct 28, 2024
  3. Patrick SteinhardtOct 28, 2024
  4. Usman AkinyemiOct 28, 2024
  5. Patrick SteinhardtOct 28, 2024
  6. Christian CouderOct 28, 2024
  7. Usman AkinyemiOct 28, 2024
  8. Usman AkinyemiOct 28, 2024
  9. Christian CouderOct 29, 2024
  10. Usman AkinyemiOct 29, 2024
  11. Usman AkinyemiOct 29, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.