Re: Inconsistent handling of corrupt patches based on line endings

From: Taylor Blau <me@ttaylorr.com>
Date: Oct 28, 2024, 18:11 UTC
Message-ID: <Zx/TwhuG4Ni7mf6F@nand.local>
In-Reply-To: <CAExmRTbMCayh+vHW3g=2p=FMb=VKXomEbn7_0t+kK-eF79JnEA@mail.gmail.com>

On Mon, Oct 28, 2024 at 05:57:54PM +0100, Peregi Tamás wrote:

Show 7 quoted lines

> Hi all,
>
> I might've found an inconsistency in how git-apply treats corrupt patches
> (representing empty context lines with completely empty lines instead of
> lines containing a single space - usually a result of a "trim trailing
> whitespace" editor setting) based on whether the patch file uses
> Windows-style line endings (CRLF) or Unix-style line endings (LF only).

Let's see if any recent apply.c folks have thoughts...:

$ git shortlog -nse --no-merges --since=3.years.ago.. -- apply.c
    21  Elijah Newren <newren@gmail.com>
    12  Patrick Steinhardt <ps@pks.im>
     7  Ævar Arnfjörð Bjarmason <avarab@gmail.com>
     5  Junio C Hamano <gitster@pobox.com>
     4  Jeff King <peff@peff.net>
     4  René Scharfe <l.s.r@web.de>

Thanks, Taylor