Re: [PATCH] diff-highlight: link to diff-highlight in DESTDIR #Makefile #diff-highlight
- From
Taylor Blau <me@ttaylorr.com>
- Date
- Oct 12, 2024, 15:50 UTC
- Message-ID
- <Zwqa3YFt9+dfKmHM@nand.local>
- In-Reply-To
- <pull.938.git.git.1728745399993.gitgitgadget@gmail.com>
On Sat, Oct 12, 2024 at 03:03:19PM +0000, immeëmosol via GitGitGadget wrote:
Show 9 quoted lines
> diff --git a/contrib/diff-highlight/Makefile b/contrib/diff-highlight/Makefile > index f2be7cc9243..10c588a7929 100644 > --- a/contrib/diff-highlight/Makefile > +++ b/contrib/diff-highlight/Makefile > @@ -9,6 +9,7 @@ diff-highlight: shebang.perl DiffHighlight.pm diff-highlight.perl > cat $^ >$@+ > chmod +x $@+ > mv $@+ $@ > + ln --symbolic --target-directory=$(DESTDIR) $(abspath $@)
Hmm. I am not opposed to having diff-highlight's Makefile be responsible for installing a symbolic link to the generated script, but I do not think that this Makefile recipe is the right place to do it.
This recipe is about building the executable, not installing it. If you want to introduce a separate .PHONY recipe for installing the script, I think that would be a better place to introduce this change.
Thanks, Taylor