Re: [PATCH 1/3] fuzz: port fuzz-credential-from-url-gently from OSS-Fuzz

From: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Date: Oct 11, 2024, 09:13 UTC
Message-ID: <ZwjsK-uprX0eUAl5@ugly>
In-Reply-To: <625b8d607ed2c95e396e7794616d9f290f23d15c.1728594659.git.steadmon@google.com>

just some nits:

On Thu, Oct 10, 2024 at 02:11:53PM -0700, Josh Steadmon wrote:

Show 9 quoted lines

>+++ b/ci/run-build-and-minimal-fuzzers.sh
>+fuzzers="
>+commit-graph \
>+config \
>+credential-from-url-gently \
>+date \
>+pack-headers \
>+pack-idx \
>+"

the trailing space-backslashes can be left out, which would make the code less noisy. then the variable would contain linebreaks instead of spaces, which the for loop would be just fine with (as $IFS contains LF).

>+for fuzzer in $fuzzers ; do
>

the space before the semicolon seems excessive.

>+++ b/oss-fuzz/fuzz-credential-from-url-gently.c
>+int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size);
>+

are these seemingly redundant prototypes meant to suppress compiler warnings?

>+int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size)
>+{