Re: git grep does not find all occurrences on macOS

From: Taylor Blau <me@ttaylorr.com>
Date: Oct 15, 2024, 00:26 UTC
Message-ID: <Zw22sTxyWCbczZy8@nand.local>
In-Reply-To: <771C9C4E-45F1-4F71-B3A9-4E8E4A9CAC1F@sigma-star.at>

On Mon, Oct 14, 2024 at 03:34:02PM +0200, David Gstir wrote:

Show 12 quoted lines

> Hi!
>
> I encountered rather subtle issue on in git 2.47.0 on macOS 14.7 (installed from Homebrew):
>
> git grep will not find all occurrences of string patterns containing a “.” under some
> conditions. In my case I have an ISO-8859 encoded text file which contains umlauts.
> If the string I’m grepping for occurs after a non-ASCII character in this file, git grep
> will not find it.
>
> I’ve put up a reproducer here https://github.com/iokill/repro-git-grep-issue, but the gist
> of it is "git grep quz.baz" on the ISO-8859-encoded file below will not return anything,
> when it should return the line "quz.baz=3":

Interesting. I have a macOS system, but don't build Git on it regularly enough to test.

I CC'd some other active contributors who have recently touched grep.c, perhaps they may have a better insight into what is going on here.

Thanks, Taylor