Re: Local git server can't serve https until repos owned by http, can't serve ssh unless repos owned by user after 2.45.1
- From
Michal Suchánek <msuchanek@suse.de>
- Date
- Sep 25, 2024, 11:34 UTC
- Message-ID
- <ZvP1P31xSvKaAhjN@kitsune.suse.cz>
- In-Reply-To
- <xmqq4j9fzge5.fsf@gitster.g>
On Wed, Jun 26, 2024 at 11:51:46AM -0700, Junio C Hamano wrote:
Show 12 quoted lines
> Phillip Wood <phillip.wood123@gmail.com> writes: > > > Sorry if I wasn't clear. "." is considered safe with "safe.directory = > > *" but I was looking at why it was not considered safe when using > > repository paths in safe.directory. > > Ahh, OK. We tell them /home/wood/repo/git is a good repository to > visit, but daemon's call to ensure_valid_ownership() asks "I am in > the '.' directory; does that match /home/wood/repo/git?" > > That sucks. I agree with your idea that we'd need to canonicalize > both before comparing.
And it's addressed with 0ed3dde067a5dc5141e3a31d950972f00a08b35d at least since 2.46.1
Thanks
Michal