Re: [PATCH 1/4] git: pass in repo for RUN_SETUP_GENTLY

From: shejialuo <shejialuo@gmail.com>
Date: Sep 24, 2024, 15:24 UTC
Message-ID: <ZvLZqIe8rpGZTU0C@ArchLinux>
In-Reply-To: <eceb2d835be7168081d6eeffbce57bba89b5f423.1727185364.git.gitgitgadget@gmail.com>

On Tue, Sep 24, 2024 at 01:42:41PM +0000, John Cai via GitGitGadget wrote:

[snip]

Show 6 quoted lines

> diff --git a/git.c b/git.c
> index 2fbea24ec92..e31b52dcc50 100644
> --- a/git.c
> +++ b/git.c
> @@ -480,7 +480,10 @@ static int run_builtin(struct cmd_struct *p, int argc, const char **argv, struct
>  	trace2_cmd_name(p->cmd);

This line is a little long, we may clean this in this patch.

Show 7 quoted lines

>  
>  	validate_cache_entries(repo->index);
> -	status = p->fn(argc, argv, prefix, (p->option & RUN_SETUP)? repo : NULL);
> +	status = p->fn(argc,
> +		       argv,
> +		       prefix,
> +		       ((p->option & RUN_SETUP) || (p->option & RUN_SETUP_GENTLY))? repo : NULL);

This reads so strange, could we create a new variable here?

Small problems, don't worth a reroll.

Thanks, Jialuo