Re: [PATCH] cbtree: fix a typo

From: Patrick Steinhardt <ps@pks.im>
Date: Sep 16, 2024, 07:30 UTC
Message-ID: <Zufef70mfdUwSwnY@pks.im>
In-Reply-To: <20240915230522.129253-1-algonell@gmail.com>

On Mon, Sep 16, 2024 at 02:05:22AM +0300, Andrew Kreimer wrote:

> Fix a typo in comments.
> 
> Signed-off-by: Andrew Kreimer <algonell@gmail.com>

Thanks for these fixes, all three of them look good to me. For future such patch series I'd recommend to send a single series that combines such related fixes. It makes it a bit easier to keep track of these similar patches and review them in one go.

Show 17 quoted lines

> ---
>  cbtree.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/cbtree.c b/cbtree.c
> index c1cc30a5dc..cf8cf75b89 100644
> --- a/cbtree.c
> +++ b/cbtree.c
> @@ -12,7 +12,7 @@ static struct cb_node *cb_node_of(const void *p)
>  	return (struct cb_node *)((uintptr_t)p - 1);
>  }
>  
> -/* locate the best match, does not do a final comparision */
> +/* locate the best match, does not do a final comparison */
>  static struct cb_node *cb_internal_best_match(struct cb_node *p,
>  					const uint8_t *k, size_t klen)
>  {

We might convert this to be a proper sentence while at it, namely s/locate/Locate/ and s/comparison/&./. But no need to reroll this patch for that, as your change is a strict improvement by itself already.

Thanks!

Patrick