Re: [PATCH 0/6] refs/reftable: wire up exclude patterns

> Patrick Steinhardt <ps@pks.im> writes:
> 
> > Hi,
> >
> > this patch series wires up exclude patterns for the reftable backend.
> > Exclude patterns allow the backend to skip references internally that
> > match a specific pattern. This avoids having to read references that the
> > caller would discard immediately anyway.
> >
> > The series is structured as follows:
> >
> >   - Patches 1 and 2 fix two separate bugs in how we currently handle
> >     exclude patterns in combination with namespaces. We didn't happen to
> >     stumble over these bugs before because exclude patterns are only
> >     implemented for the "packed" backend. But once you start to pack
> >     refs we exclude references based on their full name instead of the
> >     name with the prefixed stripped. For the reftable backend we'd
> >     always hit those bugs because it always uses exclude patterns when
> >     passed.
> >
> >   - Patches 3 to 5 wire up proper re-seeking of reftable iterators and
> >     adds some tests to demonstrate that this works as expected. This is
> >     a prerequisite for handling exclude patterns.
> >
> >   - Patch 6 wires up exclude patterns in the reftable backend by
> >     re-seeking iterators once we hit an excluded reference.
> >
> > Thanks!
> >
> > Patrick
> >
> 
> This was a bit more intensive so I took my time with the review. Overall
> I have some questions/comments. But the series looks good. Thanks!