git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: curl 8.10.0 regression breaks uploads with HTTP/2 and http.postbuffer

From
Patrick Steinhardt <ps@pks.im>
Date
Sep 13, 2024, 11:21 UTC
Message-ID
<ZuQgFVuokIQs2ZeF@pks.im>
In-Reply-To
<o8o7sn01-p918-34s5-387p-pprqo7499p8s@unkk.fr>
On Fri, Sep 13, 2024 at 01:04:57PM +0200, Daniel Stenberg wrote:
Show 15 quoted lines
> On Fri, 13 Sep 2024, Patrick Steinhardt wrote:
> 
> >  - In there we hit the `large_request` code path. We set up
> >    CURLOPT_READFUNCTION and CURLOPT_SEEKFUNCTION. The callback that
> >    uses our buffer is the one set up via CURLOPT_READFUNCTION, which is
> >    `rpc_out()`.
> 
> Thanks, I ended up able to write a stand-alone reproducer. Stefan Eissing
> wrote up a fix that seems to fix the case for us at least and it would be
> great if you could test this in your end:
> 
>   https://github.com/curl/curl/pull/14895
> 
> The actual code patch is tiny. The PR is mostly about adding test cases to
> reproduce and verify.

I can confirm that this pull request fixes the regression. Thanks a bunch for the quick turnaround, highly appreciated!

Patrick
Previous: Daniel StenbergNext: Junio C Hamano
Message 8 of 9 in “curl 8.10.0 regression breaks uploads with HTTP/2 and http.postbuffer”
  1. Patrick SteinhardtSep 13, 2024
  2. Daniel StenbergSep 13, 2024
  3. Daniel StenbergSep 13, 2024
  4. Patrick SteinhardtSep 13, 2024
  5. Daniel StenbergSep 13, 2024
  6. Patrick SteinhardtSep 13, 2024
  7. Daniel StenbergSep 13, 2024
  8. Patrick SteinhardtSep 13, 2024
  9. Junio C HamanoSep 19, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.