Re: curl 8.10.0 regression breaks uploads with HTTP/2 and http.postbuffer
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Sep 13, 2024, 11:21 UTC
- Message-ID
- <ZuQgFVuokIQs2ZeF@pks.im>
- In-Reply-To
- <o8o7sn01-p918-34s5-387p-pprqo7499p8s@unkk.fr>
On Fri, Sep 13, 2024 at 01:04:57PM +0200, Daniel Stenberg wrote:
Show 15 quoted lines
> On Fri, 13 Sep 2024, Patrick Steinhardt wrote: > > > - In there we hit the `large_request` code path. We set up > > CURLOPT_READFUNCTION and CURLOPT_SEEKFUNCTION. The callback that > > uses our buffer is the one set up via CURLOPT_READFUNCTION, which is > > `rpc_out()`. > > Thanks, I ended up able to write a stand-alone reproducer. Stefan Eissing > wrote up a fix that seems to fix the case for us at least and it would be > great if you could test this in your end: > > https://github.com/curl/curl/pull/14895 > > The actual code patch is tiny. The PR is mostly about adding test cases to > reproduce and verify.
I can confirm that this pull request fixes the regression. Thanks a bunch for the quick turnaround, highly appreciated!
Patrick