Re: Permission issue in Git in DrvFs-mounted network drives

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Sep 20, 2024, 20:43 UTC
Message-ID: <Zu3ec1mDj9JD1Bbj@tapette.crustytoothpaste.net>
In-Reply-To: <19210b887c6.f59622352625372.1022723129771458212@orca.pet>

On 2024-09-20 at 18:36:21, Marcos Del Sol Vives wrote:

Show 8 quoted lines

> ---- El Fri, 20 Sep 2024 17:51:57 +0200,  brian m. carlson  escribió ----
> > Other folks may feel differently about fixing this, but I would suggest
> > against it.
> 
> I understand that it's a workaround required due to non-POSIX compliance,
> but considering it should have no impact on any other OS and will actually
> as you said make buggy NFS mount work, IMHO it'd be still nice to have
> the changes made.

Git could, in theory, accept a patch here. However, you're also going to have lots of other software that breaks in this case, not just Git. So it's less useful to patch Git and hundreds of other packages on Linux distributions that have relied on the POSIX standard and more useful to fix your OS (or maybe switch to WSL2, if that doesn't have the problem). Most Linux distros will generally not be interested in fixing this class of problem, in my experience.

In addition, chmod doesn't always work under WSL. I believe it _does_ work if the drive is mounted with metadata, but some people don't have that enabled and I don't know if it works for all drives. For those people, the current code will work, since it doesn't call chmod or fchmod, but it will fail with your patch.

-- 
brian m. carlson (they/them or he/him)
Toronto, Ontario, CA