Re: [PATCH v2 0/3] sparse-checkout file handle leak fix

From: Patrick Steinhardt <ps@pks.im>
Date: Sep 6, 2024, 09:25 UTC
Message-ID: <ZtrKf4CW_vxJt9eA@pks.im>
In-Reply-To: <20240906034557.GA3693911@coredump.intra.peff.net>

On Thu, Sep 05, 2024 at 11:45:57PM -0400, Jeff King wrote:

Show 9 quoted lines

> Here's a re-roll that fixes the use-after-free of the lock filename that
> Patrick noticed. I pulled the error-checking fix into its own patch
> (patch 2 here), and did Junio's suggested "goto out" as preparation in
> patch 1. Patch 3 is the leak fix.
> 
> Range diff is below, but it's much harder to read than just looking at
> the updated patch 3.
> 
> Thanks both for review on round 1.

Thanks for going the extra steps! This version looks good to me.

Patrick