Re: [PATCH 2/2] grep: prefer UNUSED to MAYBE_UNUSED for pcre allocators

From: Patrick Steinhardt <ps@pks.im>
Date: Aug 30, 2024, 06:39 UTC
Message-ID: <ZtFpGjBFlMNPnSld@tanuki>
In-Reply-To: <20240829200953.GB432235@coredump.intra.peff.net>

On Thu, Aug 29, 2024 at 04:09:53PM -0400, Jeff King wrote:

Show 15 quoted lines

> We prove custom malloc/free callbacks for the pcre library to use. Those
> take an extra "data" parameter, but we don't use it. Back when these
> were added in 513f2b0bbd (grep: make PCRE2 aware of custom allocator,
> 2019-10-16), we only had MAYBE_UNUSED. But these days we have UNUSED,
> which we should prefer, as it will let the compiler inform us if the
> code changes to actually use the parameters.
> 
> I also moved the annotations to come after the variable name, which is
> how we typically spell it.
> 
> Signed-off-by: Jeff King <peff@peff.net>
> ---
> Where "how we typically spell it" is "me", because I wrote 99% of the
> annotations we have. ;) I'm open to debate, but only if it is
> accompanied by a patch to change all of them to be consistent.

I don't care about the order, but if we settle on one I think we should also document this accordingly in our code style guide.

In any case, the patch series looks obviously good, except for the one typo that Eric already pointed out.

Thanks!

Patrick