Re: [PATCH] remote: plug memory leaks at early returns

From: Patrick Steinhardt <ps@pks.im>
Date: Aug 26, 2024, 05:36 UTC
Message-ID: <ZswUWj_dg7-kM8b0@tanuki>
In-Reply-To: <xmqqseuvndsq.fsf@gitster.g>

On Fri, Aug 23, 2024 at 02:13:09PM -0700, Junio C Hamano wrote:

Show 11 quoted lines

> René Scharfe <l.s.r@web.de> writes:
> 
> > Signed-off-by: René Scharfe <l.s.r@web.de>
> > ---
> >  builtin/remote.c | 23 +++++++++++++++--------
> >  1 file changed, 15 insertions(+), 8 deletions(-)
> 
> Looks straight-forward.  Does this allow us to mark any test script
> as leak-free?  I understand that Patrick has another round of
> leakfixes topic that is not yet published, and I'd prefer to see us
> not step each other's toes.

No, this doesn't conflict with anything I have. And even if it did, I'd be happy to drop some patches from my local series :)

The changes themselves also look good to me, thanks!

Patrick