Re: [PATCH] transport: fix leak with transport helper URLs

From: Patrick Steinhardt <ps@pks.im>
Date: Aug 8, 2024, 04:52 UTC
Message-ID: <ZrRPD0ggZapZym7E@tanuki>
In-Reply-To: <xmqq34nfn7ip.fsf@gitster.g>

On Wed, Aug 07, 2024 at 06:11:10PM -0700, Junio C Hamano wrote:

Show 10 quoted lines

> Transport URLs can be prefixed with "foo::", which would tell us that
> the transport uses a remote helper called "foo". We extract the helper
> name by `xstrndup()`ing the prefix before the double-colons, but never
> free that string.
> 
> Fix this leak by assigning the result to a separate local variable that
> we can then free upon returning.
> 
> Helped-by: Patrick Steinhardt <ps@pks.im>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>

I saw that you've merged this to `next` already, but: this looks good to me, thanks!

Patrick