git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Switch grep from non-portable BRE to portable ERE

From
Marcel Telka <marcel@telka.sk>
Date
May 17, 2024, 18:50 UTC
Message-ID
<Zkem21e_kdVfZsVV@telcontar>
In-Reply-To
<xmqq7cfsiaff.fsf@gitster.g>
On Fri, May 17, 2024 at 11:02:28AM -0700, Junio C Hamano wrote:
> Thanks for this and other portability patches.  You are porting to a
> new platform, I presume, where either nobody else ported to before
> or those who ported did not bother reporting test breakages to us?

Unfortunately, the latter is the case. I'm doing this for OpenIndiana (an illumos distro, Solaris descendant) and the testing status before I started the work was:

failed test(s): t0211 t0600 t1404 t1700 t2501 t3404 t4150 t4202 t7609 t9001 t9118 t9210 t9902

fixed 1 success 29241 failed 38 broken 269 total 30158

Now all tests pass.

The work uncovered few bugs in illumos as well. For example, this one helped to find issues with grep's null RE cases in git tests: https://www.illumos.org/issues/16561

Thank you.
-- 
+-------------------------------------------+
| Marcel Telka   e-mail:   marcel@telka.sk  |
|                homepage: http://telka.sk/ |
+-------------------------------------------+
Previous: Junio C HamanoNext: Marcel Telka
Message 3 of 4 in “Switch grep from non-portable BRE to portable ERE”
  1. Switch grep from non-portable BRE to portable EREMarcel Telka, May 17, 2024
  2. Junio C HamanoMay 17, 2024
  3. Marcel TelkaMay 17, 2024
  4. Marcel TelkaMay 17, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.