git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] t/t4202-log.sh: fix misspelled variable

From
Marcel Telka <marcel@telka.sk>
Date
May 17, 2024, 13:40 UTC
Message-ID
<ZkdeMLeDUsAAqYBL@telcontar>

The GPGSSH_GOOD_SIGNATURE_TRUSTED variable was spelled as GOOD_SIGNATURE_TRUSTED and so the grep was used the null RE that matches everything.

Signed-off-by: Marcel Telka <marcel@telka.sk>
---
 t/t4202-log.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/t4202-log.sh b/t/t4202-log.sh
index 60fe60d761..86c695eb0a 100755
--- a/t/t4202-log.sh
+++ b/t/t4202-log.sh
@@ -2022,7 +2022,7 @@ test_expect_success GPGSM 'log --graph --show-signature x509' '
 test_expect_success GPGSSH 'log --graph --show-signature ssh' '
 	test_config gpg.ssh.allowedSignersFile "${GPGSSH_ALLOWED_SIGNERS}" &&
 	git log --graph --show-signature -n1 signed-ssh >actual &&
-	grep "${GOOD_SIGNATURE_TRUSTED}" actual
+	grep "${GPGSSH_GOOD_SIGNATURE_TRUSTED}" actual
 '
 
 test_expect_success GPGSSH,GPGSSH_VERIFYTIME 'log shows failure on expired signature key' '
Message 1 of 1 in “t/t4202-log.sh: fix misspelled variable”
  1. t/t4202-log.sh: fix misspelled variableMarcel Telka, May 17, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.