git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t/t0211-trace2-perf.sh: fix typo patern -> pattern

From
Patrick Steinhardt <ps@pks.im>
Date
May 16, 2024, 04:17 UTC
Message-ID
<ZkWI9--gMH0Xgv3f@tanuki>
In-Reply-To
<ZkU8VAUnKx_SXU5U@telcontar>
On Thu, May 16, 2024 at 12:51:00AM +0200, Marcel Telka wrote:

Thanks for the patch, which looks obviously good to me. It would be nice to have a short explanation in the commit message that explains why this issue was able to sneak.

Patrick
Show 19 quoted lines
> Signed-off-by: Marcel Telka <marcel@telka.sk>
> ---
>  t/t0211-trace2-perf.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/t/t0211-trace2-perf.sh b/t/t0211-trace2-perf.sh
> index 13ef69b92f..070fe7a5da 100755
> --- a/t/t0211-trace2-perf.sh
> +++ b/t/t0211-trace2-perf.sh
> @@ -233,7 +233,7 @@ have_counter_event () {
>  
>  	pattern="d0|${thread}|${event}||||${category}|name:${name} value:${value}" &&
>  
> -	grep "${patern}" ${file}
> +	grep "${pattern}" ${file}
>  }
>  
>  test_expect_success 'global counter test/test1' '
> 
Previous: Marcel TelkaNext: Junio C Hamano
Message 2 of 3 in “t/t0211-trace2-perf.sh: fix typo patern -> pattern”
  1. t/t0211-trace2-perf.sh: fix typo patern -> patternMarcel Telka, May 15, 2024
  2. Patrick SteinhardtMay 16, 2024
  3. Junio C HamanoMay 16, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.