Re: Git 2.45.1 - What is the right way to clone with global hooks disabled?

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: May 15, 2024, 22:25 UTC
Message-ID: <ZkU2Vao8yBHYdUmJ@tapette.crustytoothpaste.net>
In-Reply-To: <FAFA34CB-9732-4A0A-87FB-BDB272E6AEE8@alchemists.io>

On 2024-05-15 at 15:53:26, Brooke Kuhlmann wrote:

Show 11 quoted lines

> Hello. 👋
> 
> With the release of Git 2.45.1, I can no longer do this when cloning trusted repositories (my own) for build and deployment purposes:
> 
> git clone --config core.hooksPath=/dev/null https://github.com/bkuhlmann/infusible
> 
> I have automation in place where I want my global Git Hooks to be ignored when cloning like this. The solution is to do this:
> 
> GIT_CLONE_PROTECTION_ACTIVE=false git clone --config core.hooksPath=/dev/null https://github.com/bkuhlmann/infusible
> 
> ...but is there a better, more secure, way to clone a repository while ignoring any global Git Hooks from firing without a lot of effort?

I think the solution you have is the best one for 2.45.1 right now. The patches which introduced this change also introduced a regression with Git LFS, and I've proposed two revert patches, which would also restore the old behaviour for you.

My reverts are somewhat controversial and there's been two different approaches proposed, but I don't believe they will solve your problem, so if the reverts are not merged, then I think the solution you have is the best one for now. It's possible someone could send a different patch to address your use case, but I don't know of any plans to do so at the moment.

I didn't see my patches in seen earlier, but it's possible that Junio has just been busy with other things and may pick them up (or not) in the future.

If they're not adopted, while I'm not personally planning to send patches for your use case, I do think it's a valuable and useful use case for us to have and consider, so I hope someone does send a patch separately.

[0] https://lore.kernel.org/git/ZkO-b6Nswrn9H7Ed@tapette.crustytoothpaste.net/T/

-- 
brian m. carlson (they/them or he/him)
Toronto, Ontario, CA