Re: [PATCH 0/6] pack-bitmap: various pack-bitmap-write cleanups
- From
Patrick Steinhardt <ps@pks.im>
- Date
- May 15, 2024, 09:05 UTC
- Message-ID
- <ZkR61b5fWoRCv18D@tanuki>
- In-Reply-To
- <cover.1715716605.git.me@ttaylorr.com>
On Tue, May 14, 2024 at 03:56:46PM -0400, Taylor Blau wrote:
Show 14 quoted lines
> This topic was born out of tb/pseudo-merge-bitmaps, which has a few > quality-of-life improvements in the pack-bitmap machinery. > > The main changes are to remove the static 'struct bitmap_writer', drop > one unused fields, and start using another unused one (see "move > commit_positions into commit_pos fields"). > > There are other smaller changes, too, like cleaning up the flag > allocation table in object.h, as well as introducing a new > bitmap_writer_free() function. > > The next round of tb/pseudo-merge-bitmaps will be based on this branch. > > Thanks in advance for your review!
I've got some tiny nits, but overall this series looks good to me already. I don't mind if it's merged in the current state if you don't think any of the nits are worthy to be addressed.
Thanks for this cleanup!
Patrick