Re: Error: failed to store: -25299

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: May 10, 2024, 23:00 UTC
Message-ID: <Zj6nFPQBKJg8q7JV@tapette.crustytoothpaste.net>
In-Reply-To: <20240510221323.GA1971112@coredump.intra.peff.net>

On 2024-05-10 at 22:13:23, Jeff King wrote:

Show 10 quoted lines

> I would have assumed this was an issue going back to 2011, since each of
> those fetches is going to try storing the successful credential. But if
> older-but-recent versions of Git did not have the problem, it could be
> that we are being more aggressive about invoking storage for some
> reason. Can you bisect?
> 
> The obvious recent changes to the credential code were brian's
> capability/state series, but those are not yet in a released version
> (and from a quick scan I did not see anything that would obviously
> change things there).

Yeah, this sounds like a change to the osxkeychain helper. There were some changes there in 2.45 that could in theory be related that weren't in 2.43 or 2.44, but I must admit not being very familiar with the macOS keychain tooling, so it's hard for me to say for certain.

My changes aren't in a released version and I haven't touched the osxkeychain helper (since I don't have a Mac), so I think it's unlikely to be related, but of course if someone finds a bug, I'm very open to fixing it.

-- 
brian m. carlson (they/them or he/him)
Toronto, Ontario, CA