Re: What's cooking in git.git (Apr 2024, #10; Mon, 29)

From: Patrick Steinhardt <ps@pks.im>
Date: Apr 29, 2024, 18:05 UTC
Message-ID: <Zi_hhpoXHrCz2kcf@tanuki>
In-Reply-To: <xmqqplu8ulra.fsf@gitster.g>

On Mon, Apr 29, 2024 at 10:22:33AM -0700, Junio C Hamano wrote:

Show 14 quoted lines

> * ps/the-index-is-no-more (2024-04-18) 6 commits
>  - repository: drop `initialize_the_repository()`
>  - repository: drop `the_index` variable
>  - builtin/clone: stop using `the_index`
>  - repository: initialize index in `repo_init()`
>  - builtin: stop using `the_index`
>  - t/helper: stop using `the_index`
> 
>  The singleton index_state instance "the_index" has been eliminated
>  by always instantiating "the_repository" and replacing references
>  to "the_index"  with references to its .index member.
> 
>  Will merge to 'next'?
>  source: <cover.1713442061.git.ps@pks.im>

I'd be happy to see it gone as one more step towards less global state. It may be debatable whether the index should really be contained in `struct repository`, but even if we ultimately decide that it is not, dropping `the_index` would be a necessary step into that direction anyway.

So yeah, I'd be happy to see `the_index` gone. From thereon we can continue to iterate.

Show 18 quoted lines

> * ps/reftable-write-optim (2024-04-08) 11 commits
>  - reftable/block: reuse compressed array
>  - reftable/block: reuse zstream when writing log blocks
>  - reftable/writer: reset `last_key` instead of releasing it
>  - reftable/writer: unify releasing memory
>  - reftable/writer: refactorings for `writer_flush_nonempty_block()`
>  - reftable/writer: refactorings for `writer_add_record()`
>  - refs/reftable: don't recompute committer ident
>  - reftable: remove name checks
>  - refs/reftable: skip duplicate name checks
>  - refs/reftable: perform explicit D/F check when writing symrefs
>  - refs/reftable: fix D/F conflict error message on ref copy
> 
>  Code to write out reftable has seen some optimization and
>  simplification.
> 
>  Will merge to 'next'?
>  source: <cover.1712578837.git.ps@pks.im>

This series has seen reviews and I don't have any remaining things to address here, so I think it's ready to go.

Patrick