Re: [PATCH v2] pack-bitmap: gracefully handle missing BTMP chunks

From: Taylor Blau <me@ttaylorr.com>
Date: Apr 15, 2024, 22:51 UTC
Message-ID: <Zh2vhDraCnqw4YFL@nand.local>
In-Reply-To: <xmqqil0io762.fsf@gitster.g>

On Mon, Apr 15, 2024 at 10:41:09AM -0700, Junio C Hamano wrote:

Show 12 quoted lines

> Patrick Steinhardt <ps@pks.im> writes:
>
> >> Helped-by: Taylor Blau <me@ttaylorr.com>
> >> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> >
> > Junio, it would be great if we could still land this fix in Git v2.45
> > given that it is addressing a regression in Git v2.44. This of course
> > assumes that the current version of this patch looks good to Taylor.
>
> Indeed.  It would be nice to see an acked by or something.
>
> Will queue, in the meantime.  Thanks for a ping.

I took a look, and I think the patch is good. I have a couple of notes on the test that I would prefer to see addressed before merging it down, though.

Thanks, Taylor