Re: GSoC 2024 [PATCH v2] Fix Git command exit code suppression in test script t2104-update-index-skip-worktree.sh

From: Patrick Steinhardt <ps@pks.im>
Date: Apr 2, 2024, 17:23 UTC
Message-ID: <Zgw_KJ3wO-x2LXI0@tanuki>
In-Reply-To: <CAPig+cRtzbv57=k7ti0YcsRR05gz4v_gExgwi6qCtT6f0i2oKA@mail.gmail.com>

On Tue, Apr 02, 2024 at 01:20:53PM -0400, Eric Sunshine wrote:

Show 12 quoted lines

> On Tue, Apr 2, 2024 at 7:06 AM Patrick Steinhardt <ps@pks.im> wrote:
> > I assume two things happened:
> >
> >   - Your patch may have changed line endings. Please make sure that your
> >     editor writes Unix-style line endings ("\n"), only.
> >
> >   - You seem to have changed indentation from four spaces to two spaces.
> 
> Micro correction: Documentation/CodingGuidelines says this:
> 
>     We use tabs to indent, and interpret tabs as taking up
>     to 8 spaces.

Huh, that's even weirder. The diff changes indentation from four spaces to two spaces for me.

Patrick