Re: [PATCH 14/15] builtin/gc: forward git-gc(1)'s `--auto` flag when packing refs
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Mar 25, 2024, 09:10 UTC
- Message-ID
- <ZgE_m8qP8Ng7omhR@tanuki>
- In-Reply-To
- <CAOLa=ZTWvLkzdJMOS4nU=zGhmXS2nSEXzK3Wo2+=jRgV56atrA@mail.gmail.com>
On Wed, Mar 20, 2024 at 04:56:31PM -0700, Karthik Nayak wrote:
Show 14 quoted lines
> Patrick Steinhardt <ps@pks.im> writes: > > > Forward the `--auto` flag to git-pack-refs(1) when it has been invoked > > with this flag itself. This does not change anything for the "files" > > backend, which will continue to eagerly pack refs. But it does ensure > > that the "reftable" backend only compacts refs as required. > > > > This change does not impact git-maintenance(1) as it won't ever end up > > executing the pack-refs task when run with `--auto`. > > > > I'm not sure I follow this one, the man page for git-maintenance(1) > doesn't mention anything about not running pack-refs when `--auto` is > used.
I'm clarifying this further in patch 15. It's quite confusing in the first place that git-maintenance(1) doesn't ever pack refs at all when using `--auto`. I will amend the commit message to explain this better.
Patrick