Re: What's cooking in git.git (Jan 2024, #01; Tue, 2)

From: Taylor Blau <me@ttaylorr.com>
Date: Feb 26, 2024, 14:44 UTC
Message-ID: <Zdyj5RsW59b5kC7m@nand.local>
In-Reply-To: <20240225225918.GB1940392@szeder.dev>

Hi SZEDER,

On Sun, Feb 25, 2024 at 11:59:18PM +0100, SZEDER Gábor wrote:

Show 6 quoted lines

> It's great that we finally have test cases for different Bloom filter
> settings in different commit-graph layers, including a test case that
> merges those layers, but that test case doesn't check that the
> resulting merged commit-graph file contains the right settings.  And
> there is still no test case that merges layers with different Bloom
> filter versions.

Thanks for reviewing.

I'm happy to produce another round of this series that would address what you've added here.

Are there any other specific things you'd like to see addressed in a subsequent round? I want to make sure that I'm addressing all of your concerns, and avoid the need for yet another round of this series that addresses things that I could have done in the first place.

> I think adding these would be the bare minimum...  and would need more
> for due diligence.

As I said above, I'm happy to add these things in, but please do let me know if there are others.

Thanks, Taylor