Re: Segfault: git show-branch --reflog refs/pullreqs/1

From: Patrick Steinhardt <ps@pks.im>
Date: Feb 21, 2024, 09:52 UTC
Message-ID: <ZdXH39p_Bh0mCsj3@tanuki>
In-Reply-To: <CAELBRWK-bZTV0qx6_34HAgpmYwy+5Zo2E0M+4B6yZJJ3CqweTw@mail.gmail.com>

On Wed, Feb 21, 2024 at 10:48:25AM +0900, Yasushi SHOJI wrote:

> Hi all,
> 
> Does anyone see a segfault on `git show-branch --reflog refs/pullreqs/1`?

TIL. I didn't even know that git-show-branch(1) is a thing.

By default, no refs but "HEAD" and refs starting with "refs/heads/*" have a reflog. Thus, your ref "refs/pullreqs/1" won't have a reflog, and git-show-branch(1) then happily segfaults when it didn't find a reflog at all. This is of course a bug that needs fixing.

I'll send a patch in a bit, thanks for your report!

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.