Re: [PATCH v2 0/5] completion: remove hardcoded config variable names

From: Patrick Steinhardt <ps@pks.im>
Date: Feb 8, 2024, 07:42 UTC
Message-ID: <ZcSFy864re825MZu@tanuki>
In-Reply-To: <xmqq8r3w53nc.fsf@gitster.g>

On Wed, Feb 07, 2024 at 02:08:07PM -0800, Junio C Hamano wrote:

Show 21 quoted lines

> "Philippe Blain via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
> > Changes since v1:
> >
> >  * Corrected my email in PATCH 2/5 (sorry for the noise)
> >
> > v1: This series removes hardcoded config variable names in the
> > __git_complete_config_variable_name function, partly by adding a new mode to
> > 'git help'. It also adds completion for 'submodule.*' config variables,
> > which were previously missing.
> >
> > I think it makes sense to do that in the same series since it's closely
> > related, and splitting it would result in textual conflicts between both
> > series if one does not build on top of the other, but I'm open to other
> > suggestions.
> >
> > Thanks,
> 
> Neither rounds of this series unfortunately got any review.
> Comments from anybody interested in helping to improve completion
> scripts?

Well, I've spent some time with Bash completion recently, so let me give it a go. I was trying to avoid the dense Bash logic and thus shied away from reviewing it. But the end result of having less hardcoded values is quite nice indeed.

Patrick