Re: What's cooking in git.git (Feb 2024, #03; Tue, 6)

From: Kousik Sanagavarapu <five231003@gmail.com>
Date: Feb 7, 2024, 13:05 UTC
Message-ID: <ZcOADbiXv81OzztB@five231003>
In-Reply-To: <xmqqcyt9dqgi.fsf@gitster.g>

Hi,

Junio C Hamano <gitster@pobox.com> wrote:

Show 13 quoted lines

> * ak/color-decorate-symbols (2023-10-23) 7 commits
>  - log: add color.decorate.pseudoref config variable
>  - refs: exempt pseudorefs from pattern prefixing
>  - refs: add pseudorefs array and iteration functions
>  - log: add color.decorate.ref config variable
>  - log: add color.decorate.symbol config variable
>  - log: use designated inits for decoration_colors
>  - config: restructure color.decorate documentation
> 
>  A new config for coloring.
> 
>  Needs review.
>  source: <20231023221143.72489-1-andy.koppe@gmail.com>

These commits have a design conflict [1] with the series

Show 13 quoted lines

> * kn/for-all-refs (2024-01-29) 4 commits
>   (merged to 'next' on 2024-01-30 at e7a9234a8b)
>  + for-each-ref: avoid filtering on empty pattern
>  + refs: introduce `refs_for_each_all_refs()`
>  + refs: extract out `loose_fill_ref_dir_regular_file()`
>  + refs: introduce `is_pseudoref()` and `is_headref()`
> 
>  "git for-each-ref" filters its output with prefixes given from the
>  command line, but it did not honor an empty string to mean "pass
>  everything", which has been corrected.
> 
>  Reverted out of 'next' to revamp its UI.
>  source: <20240129113527.607022-1-karthik.188@gmail.com

So maybe change "Needs review" to "Not ready to be reviewed yet"? as people who read it might not be aware that it is kind of an "out-dated" (not surprising since it was sent last October) implementation and reviewing needs to be held off till a reroll is sent.

Thanks

[1] I have detailed the conflict out here:

	https://lore.kernel.org/git/ZcEvLwp0t8-rcyGn@five231003/