Re: [PATCH 1/2] t5332-multi-pack-reuse.sh: extract pack-objects helper functions

From: Taylor Blau <me@ttaylorr.com>
Date: Feb 5, 2024, 22:44 UTC
Message-ID: <ZcFk4yvj6TM2WzXn@nand.local>
In-Reply-To: <ZaeCeY-9AIR-zt7u@tanuki>

On Wed, Jan 17, 2024 at 08:32:09AM +0100, Patrick Steinhardt wrote:

Show 15 quoted lines

> > @@ -104,12 +110,7 @@ test_expect_success 'reuse objects from first pack with middle gap' '
> >  	^$(git rev-parse D)
> >  	EOF
> >
> > -	: >trace2.txt &&
> > -	GIT_TRACE2_EVENT="$PWD/trace2.txt" \
> > -		git pack-objects --stdout --delta-base-offset --revs <in >/dev/null &&
> > -
> > -	test_pack_reused 3 <trace2.txt &&
> > -	test_packs_reused 1 <trace2.txt
> > +	test_pack_objects_reused 3 1 <in
>
> This conversion causes us to drop the `--delta-base-offset` flag. It
> would be great to have an explanation in the commit message why it is
> fine to drop it.

Oops, that was unintentional. I'll resend a new round that fixes this issue shortly.

> Other than that this looks like a nice simplification to me.

Thanks for the review!

Thanks, Taylor