git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] mergetools: vimdiff: use correct tool's name when reading mergetool config

From
Fernando Ramos <greenfoo@u92.eu>
Date
Feb 15, 2024, 20:43 UTC
Message-ID
<Zc53XnK1TJVQNjOK@zacax395.localdomain>
In-Reply-To
<20240215142002.36870-1-kipras@kipras.org>
On 24/02/15 04:20PM, Kipras Melnikovas wrote:
Show 5 quoted lines
> The /mergetools/vimdiff script, which handles both vimdiff, nvimdiff
> and gvimdiff mergetools (the latter 2 simply source the vimdiff script), has a
> function merge_cmd() which read the layout variable from git config, and it
> would always read the value of mergetool.**vimdiff**.layout, instead of the
> mergetool being currently used (vimdiff or nvimdiff or gvimdiff).

You are 100% right. I completely overlooked this detail in the original implementation.

Thanks for the fix!
Previous: Junio C HamanoNext: Kipras Melnikovas
Message 4 of 8 in “mergetools: vimdiff: use correct tool's name when reading mergetool config”
  1. mergetools: vimdiff: use correct tool's name when reading mergetool configKipras Melnikovas, Feb 15, 2024
  2. mergetools: vimdiff: use correct tool's name when reading mergetool configKipras Melnikovas, Feb 15, 2024
  3. Junio C HamanoFeb 15, 2024
  4. Fernando RamosFeb 15, 2024
  5. mergetools: vimdiff: use correct tool's name when reading mergetool configKipras Melnikovas, Feb 17, 2024
  6. mergetools: vimdiff: use correct tool's name when reading mergetool configKipras Melnikovas, Feb 17, 2024
  7. Junio C HamanoFeb 20, 2024
  8. Kipras MelnikovasFeb 21, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.