git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/3] Comment style fixes

From
Patrick Steinhardt <ps@pks.im>
Date
Jan 30, 2024, 06:10 UTC
Message-ID
<ZbiSwAbRaxXXfLMk@tanuki>
In-Reply-To
<20240129202839.2234084-1-gitster@pobox.com>
On Mon, Jan 29, 2024 at 12:28:36PM -0800, Junio C Hamano wrote:
Show 8 quoted lines
> Among comments in the traditional /* single liner */ ones, our
> reviews seem to have missed a few // comments.  While they are not
> illegal per-se, they look out of place mixed with the /* ... */
> style comments, which is the prevailing style used in this project.
> 
> Fix those small number of style violations in our own code; files
> with borrowed code that have // comments as the prevalent style are
> left untouched.
These changes look obviously good to me, thanks!
Patrick
Previous: Junio C Hamano
Message 5 of 5 in “Comment style fixes”
  1. 0/3 Comment style fixesJunio C Hamano, Jan 29, 2024
  2. 1/3 builtin/worktree: comment style fixesJunio C Hamano, Jan 29, 2024
  3. 3/3 reftable/pq_test: comment style fixJunio C Hamano, Jan 29, 2024
  4. 2/3 merge-ort.c: comment style fixJunio C Hamano, Jan 29, 2024
  5. Patrick SteinhardtJan 30, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.