Re: sd/negotiate-trace-fix (was: What's cooking in git.git (Jan 2024, #06; Fri, 19))

From: Josh Steadmon <steadmon@google.com>
Date: Jan 23, 2024, 21:25 UTC
Message-ID: <ZbAu49xkxEzJ3ZkX@google.com>
In-Reply-To: <xmqqbk9ghio5.fsf@gitster.g>

On 2024.01.19 17:56, Junio C Hamano wrote: [snip]

Show 8 quoted lines

> * sd/negotiate-trace-fix (2024-01-03) 1 commit
>  - push: region_leave trace for negotiate_using_fetch
> 
>  Tracing fix.
> 
>  Waiting for a review response.
>  cf. <xmqqbka27zu9.fsf@gitster.g>
>  source: <20240103224054.1940209-1-delmerico@google.com>

Hi Junio,

Were there other open questions you had on this series? It looks like Sam answered all the questions in your xmqqbka27zu9.fsf@gitster.g reply. In your other followup you mentioned running CI with tracing enabled for all tests. This is something that we suggested before [1] but it was pretty thoroughly rejected for runtime reasons. Perhaps a more efficient check for region_enter/leave pairs could be an option, though.

[1] https://lore.kernel.org/git/cover.1564009259.git.steadmon@google.com/