Re: [PATCH v2] write-or-die: make GIT_FLUSH a Boolean environment variable

From: Taylor Blau <me@ttaylorr.com>
Date: Jan 4, 2024, 17:35 UTC
Message-ID: <ZZbsVfFpJNQHGGEn@nand.local>
In-Reply-To: <xmqq5y0a9qed.fsf@gitster.g>

On Wed, Jan 03, 2024 at 11:18:50AM -0800, Junio C Hamano wrote:

Show 7 quoted lines

> > Thanks for a nice reading - I can not imagine a better version.
>
> Yup, the flow of the logic feels very natural with this version by
> making it clear that the case that the default "-1" is returned to
> us is where we need to figure out an appropriate value ourselves.
> An added bonus is that the scope "struct stat" has is limited to the
> absolute minimum.  I like it, too.

Thanks, both.

Thanks, Taylor