Re: [PATCH 1/4] reftable/stack: refactor stack reloading to have common exit path
On Wed, Jan 10, 2024 at 09:30:51AM -0800, Junio C Hamano wrote:
Show 14 quoted lines
> Patrick Steinhardt <ps@pks.im> writes:
>
> > The `reftable_stack_reload_maybe_reuse()` function is responsible for
> > reloading the reftable list from disk. The function is quite hard to
> > follow though because it has a bunch of different exit paths, many of
> > which have to free the same set of resources.
> >
> > Refactor the function to have a common exit path. While at it, touch up
> > the style of this function a bit to match our usual coding style better.
> > ---
> > reftable/stack.c | 86 +++++++++++++++++++++++-------------------------
> > 1 file changed, 42 insertions(+), 44 deletions(-)
>
> Missing sign-off.
Ah, sorry, I forgot my usual `git rebase --signoff`. Will fix in v2.
Patrick