Re: Propose a change in open for passing in the file type.

From: Đoàn Trần Công Danh <congdanhqx@gmail.com>
Date: Dec 13, 2023, 04:17 UTC
Message-ID: <ZXkwTYD9nmPYn9UW@danh.dev>
In-Reply-To: <E1D54D98-3836-41CA-84B5-32AEAF7642D8@ibm.com>

On 2023-12-12 14:46:04+0000, Haritha D <Harithamma.D@ibm.com> wrote:

Show 18 quoted lines

> Hi Everyone,
>  
> Am working on porting git to z/OS. For reference, the pull request am working on https://github.com/git/git/pull/1537.
>  
> On z/OS there is a notion of file tag attributes. Files can be
> tagged as binary, ASCII, UTF8, EBCDIC, etc. z/OS uses these
> attributes to determine if auto-conversion is necessary. It was
> recommended in PR that we add logic directly to xopen . In order for
> me to do this in xopen , I have to pass an extra parameter to xopen
> that specifies the file type. 
>  
> Ex: 
> xopen(output_file, O_CREAT | O_WRONLY | O_TRUNC, 0666);
>  
> To :
> xopen(output_file, O_CREAT | O_WRONLY | O_TRUNC, 0666, BINARY);
>  
> BINARY: would be an enum value.

Would it work if you always open the file as BINARY? And let's all the conversion done by git via some configs (core.encoding?)?

-- 
Danh