Re: Test breakage with zlib-ng

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Dec 12, 2023, 22:18 UTC
Message-ID: <ZXjcOtQ8s60X8FEQ@tapette.crustytoothpaste.net>
In-Reply-To: <9feeb6cf-aabf-4002-917f-3f6c27547bc8@web.de>

On 2023-12-12 at 17:04:55, René Scharfe wrote:

Show 15 quoted lines

> --- >8 ---
> Subject: [PATCH] t6300: avoid hard-coding object sizes
> 
> f4ee22b526 (ref-filter: add tests for objectsize:disk, 2018-12-24)
> hard-coded the expected object sizes.  Coincidentally the size of commit
> and tag is the same with zlib at the default compression level.
> 
> 1f5f8f3e85 (t6300: abstract away SHA-1-specific constants, 2020-02-22)
> encoded the sizes as a single value, which coincidentally also works
> with sha256.
> 
> Different compression libraries like zlib-ng may arrive at different
> values.  Get them from the file system instead of hard-coding them to
> make switching the compression library (or changing the compression
> level) easier.

This definitely seems like the right thing to do. I was a bit lazy at the time and probably could have improved it then, but it's at least good that we're doing it now.

-- 
brian m. carlson (he/him or they/them)
Toronto, Ontario, CA