Re: [PATCH 3/9] imap-send: don't use git_die_config() inside callback

From: Patrick Steinhardt <ps@pks.im>
Date: Dec 11, 2023, 07:43 UTC
Message-ID: <ZXa9pz65O2B6Gwjp@tanuki>
In-Reply-To: <ZXOfrKYsmOjOHGmj@nand.local>

On Fri, Dec 08, 2023 at 05:58:52PM -0500, Taylor Blau wrote:

Show 22 quoted lines

> On Thu, Dec 07, 2023 at 09:57:55AM +0100, Patrick Steinhardt wrote:
> > On Thu, Dec 07, 2023 at 02:24:58AM -0500, Jeff King wrote:
> > [snip]
> > > diff --git a/imap-send.c b/imap-send.c
> > > index 996651e4f8..5b0fe4f95a 100644
> > > --- a/imap-send.c
> > > +++ b/imap-send.c
> > > @@ -1346,7 +1346,7 @@ static int git_imap_config(const char *var, const char *val,
> > >  		server.port = git_config_int(var, val, ctx->kvi);
> > >  	else if (!strcmp("imap.host", var)) {
> > >  		if (!val) {
> > > -			git_die_config("imap.host", "Missing value for 'imap.host'");
> > > +			return error("Missing value for 'imap.host'");
> >
> > Nit: while at it we might also mark this error for translation. Not
> > worth a reroll on its own though.
> 
> This string goes away entirely in the next patch, so I don't think we
> need to mark it here.
> 
> Thanks,
> Taylor

Ah, true. Never mind in that case.

Patrick