Re: [PATCH 4/7] builtin/clone: fix bundle URIs with mismatching object formats
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Dec 7, 2023, 07:22 UTC
- Message-ID
- <ZXFyylqzNgXwc4Lz@tanuki>
- In-Reply-To
- <CAOLa=ZQc=7Z3w9JAdzS23P=c=KSYZJR6gJSLOHdU-d92Y3kJ5A@mail.gmail.com>
On Wed, Dec 06, 2023 at 10:13:43PM +0100, Karthik Nayak wrote:
Show 12 quoted lines
> On Wed, Dec 6, 2023 at 1:40 PM Patrick Steinhardt <ps@pks.im> wrote: > > The first Git step where we expect the repository to be fully initalized > > is when we fetch bundles via bundle URIs. Funny enough, the comments > > there also state that "the_repository must match the cloned repo", which > > is indeed not necessarily the case for the hash algorithm right now. So > > in practice it is the right thing to detect the remote's object format > > before downloading bundle URIs anyway, and not doing so causes clones > > with bundle URIS to fail when the local default object format does not > > match the remote repository's format. > > > > Nit: s/URIS/URIs
Thanks, fixed locally. Will wait with v2 though until there are more review comments.
Patrick