Re: [PATCH 0/4] refs: improve handling of special refs
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Nov 30, 2023, 07:46 UTC
- Message-ID
- <ZWg97gfn80jeB3-_@tanuki>
- In-Reply-To
- <ZWe3z59WGE0+8gXN@nand.local>
On Wed, Nov 29, 2023 at 05:14:39PM -0500, Taylor Blau wrote:
Show 18 quoted lines
> On Wed, Nov 29, 2023 at 09:14:07AM +0100, Patrick Steinhardt wrote: > > Patrick Steinhardt (4): > > wt-status: read HEAD and ORIG_HEAD via the refdb > > refs: propagate errno when reading special refs fails > > refs: complete list of special refs > > bisect: consistently write BISECT_EXPECTED_REV via the refdb > > > > bisect.c | 25 +++------------ > > builtin/bisect.c | 8 ++--- > > refs.c | 64 +++++++++++++++++++++++++++++++++++-- > > t/t1403-show-ref.sh | 9 ++++++ > > t/t6030-bisect-porcelain.sh | 2 +- > > wt-status.c | 17 +++++----- > > 6 files changed, 86 insertions(+), 39 deletions(-) > > These all look pretty good to me. I had a few minor questions on the > first three patches, but I don't think they necessarily require a > reroll.
I agree that none of the comments really require a reroll, but I'll address them if there will be another iteration of this patch series.
Thanks for your review!
Patrick