Re: [PATCH 00/10] t: more compatibility fixes with reftables

From: Patrick Steinhardt <ps@pks.im>
Date: Nov 30, 2023, 07:06 UTC
Message-ID: <ZWg0hJNsIR---SVI@tanuki>
In-Reply-To: <ZWfJp80vzVhbdH89@nand.local>

On Wed, Nov 29, 2023 at 06:30:47PM -0500, Taylor Blau wrote:

Show 13 quoted lines

> On Wed, Nov 29, 2023 at 08:24:36AM +0100, Patrick Steinhardt wrote:
> > Hi,
> >
> > this is the second patch series that refactors tests to become
> > compatible with the upcoming reftables backend. It's in the same spirit
> > as the first round of patches [1], where most of the refactorings are to
> > use plumbing tools to access refs or the reflog instead of modifying
> > on-disk data structures directly.
> 
> All looks good to me. Thanks for a pleasant read :-).
> 
> Thanks,
> Taylor

If you don't mind, I'll refrain from sending a v2 only to start piping output into git-update-ref(1) directly. I'll incorporate that feedback though if there is a need for v2 due to other reasons.

Thanks for your review!

Patrick