Re: [PATCH v2 2/2] commit: detect commits that exist in commit-graph but not in the ODB

From: Taylor Blau <me@ttaylorr.com>
Date: Oct 30, 2023, 21:32 UTC
Message-ID: <ZUAg5dj272mhHPZf@nand.local>
In-Reply-To: <xmqqy1fr3kh6.fsf@gitster.g>

On Tue, Oct 24, 2023 at 12:10:13PM -0700, Junio C Hamano wrote:

Show 8 quoted lines

> > We look at a ~30% regression in general, but in general we're still a
> > whole lot faster than without the commit graph. To counteract this, the
> > new check can be turned off with the `GIT_COMMIT_GRAPH_PARANOIA` envvar.
>
> Very nicely described.  Will queue.  I'll go offline for the rest of
> the week but if there are no significant issues discovered by the
> time I come back, let's declare a victory and merge these two
> patches down to 'next'.

I think we're close here. There are a couple of small comments that I made throughout these two patches, but nothing major.

Thanks, Taylor