Re: [PATCH 1/5] ci: reorder definitions for grouping functions

From: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
Date: Oct 26, 2023, 08:26 UTC
Message-ID: <ZToin/fQiZrmUJTS@ugly>
In-Reply-To: <586a8d1003b6559177d238ceda2c6ef2f16cfb8d.1698305961.git.ps@pks.im>

On Thu, Oct 26, 2023 at 10:00:03AM +0200, Patrick Steinhardt wrote:

> [...]
>_not_ being GitLab Actions, where we define the non-stub logic in the
>

you meant GitHub here.

>else branch.
>
>Reorder the definitions such that we explicitly handle GitHub Actions.
>

i'd say something like "the conditional branches". imo that makes it clearer that you're actually talking about code, not some markup or whatever. for that matter, this is my overall impression of the commit message - it seems way too detached from the near-trivial fact that you're just slightly adjusting the code structure to make it easier to implement a cascade (aka a switch).

regards

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.