Re: What's cooking in git.git (Oct 2023, #04; Tue, 10)

From: Taylor Blau <me@ttaylorr.com>
Date: Oct 11, 2023, 19:26 UTC
Message-ID: <ZSb292VxDQoeSu2o@nand.local>
In-Reply-To: <xmqqwmvuosf3.fsf@gitster.g>

On Tue, Oct 10, 2023 at 06:32:16PM -0700, Junio C Hamano wrote:

Show 27 quoted lines

> * tb/path-filter-fix (2023-08-30) 15 commits
>  - bloom: introduce `deinit_bloom_filters()`
>  - commit-graph: reuse existing Bloom filters where possible
>  - object.h: fix mis-aligned flag bits table
>  - commit-graph: drop unnecessary `graph_read_bloom_data_context`
>  - commit-graph.c: unconditionally load Bloom filters
>  - t/t4216-log-bloom.sh: harden `test_bloom_filters_not_used()`
>  - bloom: prepare to discard incompatible Bloom filters
>  - bloom: annotate filters with hash version
>  - commit-graph: new filter ver. that fixes murmur3
>  - repo-settings: introduce commitgraph.changedPathsVersion
>  - t4216: test changed path filters with high bit paths
>  - t/helper/test-read-graph: implement `bloom-filters` mode
>  - bloom.h: make `load_bloom_filter_from_graph()` public
>  - t/helper/test-read-graph.c: extract `dump_graph_info()`
>  - gitformat-commit-graph: describe version 2 of BDAT
>
>  The Bloom filter used for path limited history traversal was broken
>  on systems whose "char" is unsigned; update the implementation and
>  bump the format version to 2.
>
>  Reroll exists, not picked up yet.
>  cf. <20230830200218.GA5147@szeder.dev>
>  cf. <20230901205616.3572722-1-jonathantanmy@google.com>
>  cf. <20230924195900.GA1156862@szeder.dev>
>  cf. <20231008143523.GA18858@szeder.dev>
>  source: <cover.1693413637.git.jonathantanmy@google.com>

Great, thanks for noting that you saw it ;-). I think that this one is ready to go, but I'm obviously biased and I'd feel better if Jonathan or Gábor (both CC'd) would take a look before you merge this down.

Show 16 quoted lines

> * tb/repack-max-cruft-size (2023-10-09) 5 commits
>   (merged to 'next' on 2023-10-09 at 38f039e880)
>  + repack: free existing_cruft array after use
>   (merged to 'next' on 2023-10-06 at b3ca6df3b9)
>  + builtin/repack.c: avoid making cruft packs preferred
>  + builtin/repack.c: implement support for `--max-cruft-size`
>  + builtin/repack.c: parse `--max-pack-size` with OPT_MAGNITUDE
>  + t7700: split cruft-related tests to t7704
>
>  "git repack" learned "--max-cruft-size" to prevent cruft packs from
>  growing without bounds.
>
>  Will merge to 'master'.
>  source: <cover.1696293862.git.me@ttaylorr.com>
>  source: <20231007172031.GA1524950@coredump.intra.peff.net>
>  source: <035393935108d02aaf8927189b05102f4f74f340.1696370003.git.me@ttaylorr.com>

Great, thanks.

The only series of mine I didn't see mentioned here was the merge ORT -> bulk-checkin stuff that I posted in [1]. The discussion there has sort of morphed beyond the patches themselves, so I'd love some review on these patches (perhaps from Elijah?, also CC'd) if time permits.

Thanks, Taylor

[1]: https://lore.kernel.org/git/cover.1696629697.git.me@ttaylorr.com/